Lower owner hashing activation slot for devnet #10244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvines I'm sure you're very busy for the upgrade party. :) But could you apply this for devnet within the timeframe of 6_500_000? If not, I'm happy to adjust the slot. This change shouln't affect testnet(tds) at all. And this isn't urgent at all as long as the compatibility isn't problematic between v1.2(devnet) and v1.3(master) branch. |
Codecov Report
@@ Coverage Diff @@
## v1.2 #10244 +/- ##
========================================
- Coverage 81.5% 81.5% -0.1%
========================================
Files 288 288
Lines 66609 66609
========================================
- Hits 54312 54295 -17
- Misses 12297 12314 +17 |
mvines
reviewed
May 26, 2020
Co-authored-by: Michael Vines <[email protected]>
mvines
approved these changes
May 26, 2020
solana-grimes
removed
the
automerge
|
💔 Unable to automerge due to CI failure |
|
devnet is now running 1.2.0, which contains this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
devnet hasn't enabled owner-included hashing due to its relatively low slot (5_850_000).
testnet (tds) has fully transitioned to the new hashing.
Summary of Changes
Lower the activation slot to gradually transition to the new hashing on devnet. This should take 2-4 days on devnet.
Contexts:
Fixes #10163
After devnet fully transitioned, we can address this: #10227.