Cli: expose last-valid-slot in solana fees #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
v1.2
automerge
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #10254 +/- ##
=======================================
Coverage 81.4% 81.4%
=======================================
Files 288 288
Lines 66620 66632 +12
=======================================
+ Hits 54281 54301 +20
+ Misses 12339 12331 -8 |
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2020
automerge (cherry picked from commit b6083ca)
CriesofCarrots
added a commit
that referenced
this pull request
May 26, 2020
automerge (cherry picked from commit b6083ca)
CriesofCarrots
added a commit
that referenced
this pull request
May 26, 2020
automerge (cherry picked from commit b6083ca) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rpc
getFeesnow exists and returns a blockhash with last-valid-slot information, but this info is not available in the Cli.Summary of Changes
solana fees, and expose last-valid-slotUseful stuff from #10162