Fix token rpc-client methods #11361
Merged
Fix token rpc-client methods #11361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Aug 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #11361 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.1%
=========================================
Files 315 315
Lines 74157 74168 +11
=========================================
+ Hits 61080 61082 +2
- Misses 13077 13086 +9 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Convert None to error in parse_keyed_accounts * Allow encoding configuration in getTokenAccounts methods (cherry picked from commit d0144ce) # Conflicts: # core/src/rpc.rs
mergify bot
added a commit
that referenced
this pull request
Aug 4, 2020
* Fix token rpc-client methods (#11361) * Convert None to error in parse_keyed_accounts * Allow encoding configuration in getTokenAccounts methods (cherry picked from commit d0144ce) # Conflicts: # core/src/rpc.rs * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getTokenAccountsByDelegateandgetTokenAccountsByOwnerattempted to be clever and return jsonParsed data by default. However, rpc_client needs access to the raw data in order to decode a proper Account struct.Summary of Changes
getAccountInfoandgetProgramAccountsFixes panic on solana-labs/solana-program-library#188