Add flatten to logs_subscribe commitment
#13859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, commitment for `logs_subscribe` must be specified using the
non-flattened form in JSON, ie `{"commitment":{"commitment":"max}}`.
This brings the commitment in line with documentation.
Codecov Report
@@ Coverage Diff @@
## master #13859 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 381 381
Lines 93231 93231
=======================================
+ Hits 76534 76542 +8
+ Misses 16697 16689 -8 |
|
thanks |
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, commitment for
logs_subscribemust be specified using thenon-flattened form in JSON, ie
{"commitment":{"commitment":"max}}.Summary of Changes
Bring commitment in line with documentation by specifying
flattenFixes #