Make exchange listening-for-deposits language stronger #14775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Jan 22, 2021
Co-authored-by: Trent Nelson <[email protected]>
ryoqun
reviewed
Jan 23, 2021
ryoqun
previously approved these changes
Jan 23, 2021
|
(kind of part of this: #13443; this is one of things I wanted to do...) |
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jan 23, 2021
* Make exchange listening-for-deposits language stronger * Update docs/src/integrations/exchange.md Co-authored-by: Trent Nelson <[email protected]> * Update from deprecated method Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 66fd187)
mergify bot
added a commit
that referenced
this pull request
Jan 23, 2021
* Make exchange listening-for-deposits language stronger * Update docs/src/integrations/exchange.md Co-authored-by: Trent Nelson <[email protected]> * Update from deprecated method Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit 66fd187) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some exchanges may interpret the "Listening for Deposits" methods as equally viable. But for exchanges with large quantities of deposit addresses, polling the address history of every one is prohibitively slow, particularly if they are targeted our public, rate-limited api nodes.
Summary of Changes
getConfirmedBlocks/getConfirmedBlockstronger