replace account index bulk insert with iterator #18198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
changed the title
jeffwashington
force-pushed
the
excess43
branch
2 times, most recently
from
fa06b1f
to
a2f51f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #18198 +/- ##
=======================================
Coverage 82.3% 82.3%
=======================================
Files 433 433
Lines 120940 120946 +6
=======================================
+ Hits 99588 99615 +27
+ Misses 21352 21331 -21 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
(cherry picked from commit e063766)
jeffwashington
added a commit
that referenced
this pull request
Jun 25, 2021
(cherry picked from commit e063766) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Account index creation is slow. Account index takes a lot of memory. During startup, there is contention for memory. Soon, the bulk accounts to be inserted will be sorted and binned inside accounts index. This work is preparation for binning account data.
Summary of Changes
During bulk creation of account index, accept an iterator instead of requiring a vector. This allows lazy evaluation and prevents having to create vectors of data that will be resorted anyway.
Fixes #