Cleanup ReplayStage test replay_blockstore_components() #18241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
FixTests
branch
2 times, most recently
from
8332499
to
2140f3f
Compare
Codecov Report
@@ Coverage Diff @@
## master #18241 +/- ##
=======================================
Coverage 82.3% 82.3%
=======================================
Files 433 433
Lines 121001 121004 +3
=======================================
+ Hits 99660 99673 +13
+ Misses 21341 21331 -10 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 68c8746) # Conflicts: # core/src/consensus.rs
carllin
added a commit
that referenced
this pull request
Jun 30, 2021
(cherry picked from commit 68c8746)
carllin
added a commit
that referenced
this pull request
Jul 1, 2021
(cherry picked from commit 68c8746)
carllin
added a commit
that referenced
this pull request
Jul 1, 2021
(cherry picked from commit 68c8746)
mergify bot
added a commit
that referenced
this pull request
Jul 1, 2021
(cherry picked from commit 68c8746) Co-authored-by: carllin <[email protected]>
Closed
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
replay_blockstore_components()has some duplicate code, and can leverage functionality fromVoteSimulatorSummary of Changes
Fixes #