Advertise storage last id #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
commented
Dec 13, 2018
src/bank.rs
Outdated
| @@ -1384,6 +1387,17 @@ impl Bank { | |||
| self.last_ids.read().unwrap().tick_height | |||
| } | |||
|
|
|||
| pub fn get_storage_last_id(&self) -> Hash { | |||
There was a problem hiding this comment.
@aeyakovenko pretend self.id is really the id of the node, is this what you're thinking of? Also, I suppose bank needs to know of the node's pubkey.
There was a problem hiding this comment.
Previous PR added interface to the validator to get its state of the storage last_id, you said it should be in the account state and advertised on-chain. This has the validator create a transaction with the id it's using and then returns it from the account state when asked for it.
sakridge
force-pushed
the
advertise-storage-last-id
branch
5 times, most recently
from
a221a03
to
4738d4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2154 +/- ##
========================================
+ Coverage 73.1% 73.7% +0.6%
========================================
Files 114 114
Lines 16974 17198 +224
========================================
+ Hits 12412 12689 +277
+ Misses 4562 4509 -53 |
aeyakovenko
approved these changes
Dec 21, 2018
sakridge
force-pushed
the
advertise-storage-last-id
branch
from
4738d4e
to
e5d4cbf
Compare
* Also implement more storage contract logic * Add transactions for proof validation, * Move storage state members into system storage account userdata
sakridge
force-pushed
the
advertise-storage-last-id
branch
from
bf38bd6
to
51630e3
Compare
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Jul 16, 2024
ruuda
pushed a commit
to ChorusOne/solana
that referenced
this pull request
Jul 24, 2024
…match cli arg (backport of solana-labs#2154) (solana-labs#2157) Removes deprecated --halt-on-known-validators-accounts-hash-mismatch cli arg (solana-labs#2154) (cherry picked from commit 4f228f4) Co-authored-by: Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Validator needs to advertise the last id it currently is using for storage
Summary of Changes
Create new transaction type and post it to the chain. Add an interface to the bank to then get it out of the account.
Fixes #2060