Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage fixes #2479

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Storage fixes #2479

merged 2 commits into from
Jan 18, 2019

Conversation

sakridge
Copy link
Member

Problem

replicators need to include the signature of the last_id hash that they used to generate the porep.

Summary of Changes

Include signature in the porep and generate samples instead of having them fixed.

Fixes #

@sakridge sakridge force-pushed the storage-fixes branch 2 times, most recently from eb58e41 to 61808d9 Compare January 17, 2019 22:59
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #2479 into master will decrease coverage by 7.4%.
The diff coverage is 12.4%.

@@           Coverage Diff            @@
##           master   #2479     +/-   ##
========================================
- Coverage    77.6%   70.1%   -7.5%     
========================================
  Files         110     110             
  Lines       17655   19237   +1582     
========================================
- Hits        13704   13502    -202     
- Misses       3951    5735   +1784

@sakridge sakridge force-pushed the storage-fixes branch 6 times, most recently from 29a7a72 to 7ce5a1c Compare January 18, 2019 20:29
* replicators generate their sample values
* fixes to replicator block height logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants