Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetMinimumDelegation (backport of #24020, #24158, #24192, #24175) #24902

Conversation

brooksprumo
Copy link
Contributor

Problem

As part of #22559, the PR to actually raise the minimum delegation (#24357) fails CI during downstream-projects when building/testing stake-pool. The stake-pool program would like to have a v1.10 of the SDK that has the new GetMinimumDelegation instruction, which it can use internally to query the value, instead of using a hard-coded literal.

Summary of Changes

Backport GetMinimumDelegation to v1.10. Due to the changes in the program-runtime (how accounts are passed in), a mergify backport will not be trivial. Instead, I've manually backported #24020, #24158, #24192, #24175 due to how much the code has diverged. Note that v1.10 will not get the feature to actually raise the minimum delegation.

The number of changes in this PR is quite large. If it's preferred, I can break it up into smaller chunks as well. There should not be any functional changes when compared to master.

Feature Gate Issue: #24057

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label May 2, 2022
@mvines
Copy link
Member

mvines commented May 2, 2022

I'd like to not introduce any new runtime changes into v1.10 at this point. A couple alternatives:

  1. Add a stub in the stake-pool until we ship v1.11.0 and update SPL to use it
  2. Wait until we ship v1.11.0 and update SPL to use it and land the dependent stake-pool changes

@brooksprumo
Copy link
Contributor Author

brooksprumo commented May 2, 2022

I'd like to not introduce any new runtime changes into v1.10 at this point.

Yeah, that's the right call. Jon and I talked and have a way to unblock this. Closing!

@brooksprumo brooksprumo closed this May 2, 2022
@brooksprumo brooksprumo deleted the v1.10/get-minimum-delegation-2 branch May 9, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants