Rollback tokio to LTS release v1.14 #25028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
approved these changes
May 6, 2022
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #25028 +/- ##
========================================
Coverage 82.0% 82.0%
========================================
Files 598 598
Lines 165882 166085 +203
========================================
+ Hits 136125 136322 +197
- Misses 29757 29763 +6 |
|
Any update on this @CriesofCarrots? |
No, sorry @fabioberger , I don't have anything new to report at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The RPC stall problem we are debugging appears when upgrading tokio from v1.15 to v1.16. Our master branch is already on tokio v1.17, which means it will suffer the stalls.
Summary of Changes
Rollback tokio, and pin to the long-term support release v1.14, until we can figure out why newer tokio breaks things.
Inspired by #24644
(Last one. Sorry for doing this in the exactly wrong order, but each of these needed a little hand-holding)