-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TransactionMessage
class
#27526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
jstarry
force-pushed
the
web3/decompile-message
branch
from
September 1, 2022 00:24
72c6339
to
e8aa3d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #27526 +/- ##
=========================================
+ Coverage 77.6% 77.7% +0.1%
=========================================
Files 54 55 +1
Lines 2770 2850 +80
Branches 379 392 +13
=========================================
+ Hits 2150 2216 +66
- Misses 484 495 +11
- Partials 136 139 +3 |
jstarry
force-pushed
the
web3/decompile-message
branch
from
September 7, 2022 03:46
e8aa3d4
to
6c74068
Compare
This was referenced Sep 28, 2022
This was referenced Oct 4, 2022
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lack of a common interface for creating and displaying transactions which supports both legacy and versioned transactions
Summary of Changes
TransactionMessage
class which can be used to construct or decompile legacy and v0 transactions.Message.compile
method to the legacy message class to mirror the equivalentMessageV0.compile
method added in feat: implement message v0 compilation #27524getAccountKeys
method to bothMessage
andMessageV0
classes for use in transaction decompilation and to allow devs to conveniently resolve account indexes with a common interface for legacy and versioned transactionsresolveAddressTableLookups
method toMessageV0
which is used to decompile v0 transactionsFixes #