Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist fee collector id #2945

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

garious
Copy link
Contributor

@garious garious commented Feb 26, 2019

Problem

When I added leader scheduling to the bank, it sent the solana_runtime crate in an awkward direction where it's not clear what functionality belongs in the runtime and what's up at the protocol level.

Summary of Changes

Return to @pgarg66's original architecture, where the creator of child banks decide whom fees should go to. Rather than calling the pubkey leader_id, this PR calls it collector_id, hoping to further distinguish runtime from protocol. I'll send a follow-up PR to pull the leader schedule back up to the protocol level as well.

@rob-solana, fyi

@garious garious requested a review from pgarg66 February 26, 2019 13:50
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2945 into master will decrease coverage by 5%.
The diff coverage is 80%.

@@           Coverage Diff            @@
##           master   #2945     +/-   ##
========================================
- Coverage    78.3%   73.2%   -5.1%     
========================================
  Files         126     126             
  Lines       19604   20949   +1345     
========================================
  Hits        15355   15355             
- Misses       4249    5594   +1345

@garious garious merged commit 3897b66 into solana-labs:master Feb 26, 2019
brooksprumo added a commit to brooksprumo/solana that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant