Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I added leader scheduling to the bank, it sent the solana_runtime crate in an awkward direction where it's not clear what functionality belongs in the runtime and what's up at the protocol level.
Summary of Changes
Return to @pgarg66's original architecture, where the creator of child banks decide whom fees should go to. Rather than calling the pubkey
leader_id
, this PR calls itcollector_id
, hoping to further distinguish runtime from protocol. I'll send a follow-up PR to pull the leader schedule back up to the protocol level as well.@rob-solana, fyi