Find and load missing programs in LoadedPrograms cache #30275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
use-program-cache
branch
5 times, most recently
from
b706e0a
to
f43f41f
Compare
pgarg66
force-pushed
the
use-program-cache
branch
3 times, most recently
from
2a89875
to
37cc11f
Compare
pgarg66
force-pushed
the
use-program-cache
branch
from
37cc11f
to
d7a80c8
Compare
pgarg66
force-pushed
the
use-program-cache
branch
from
932f1e5
to
0393038
Compare
Lichtso
reviewed
Feb 21, 2023
| @@ -43,7 +43,7 @@ impl TransactionExecutorCache { | |||
|
|
|||
| pub fn set_tombstone(&mut self, key: Pubkey) { | |||
| self.visible | |||
| .insert(key, Arc::new(LoadedProgram::new_tombstone())); | |||
| .insert(key, Arc::new(LoadedProgram::new_tombstone(0))); | |||
There was a problem hiding this comment.
This should be clock.slot not 0 because it is used for re-/un-deployment.
| /// This behaves differently than `insert_entry()` in case there's currently a program at the | ||
| /// `deploytment_slot`. It'll replace the current entry with a tombstone, whereas `insert_entry()` | ||
| /// would retain and return the current entry. | ||
| pub fn set_tombstone(&mut self, key: Pubkey, deployment_slot: Slot) -> Arc<LoadedProgram> { |
There was a problem hiding this comment.
It does not feel like the right abstraction, because all forms of un/re/deployment should use the same insert method, including tombstones.
However, the current insert method covers both: Normal loading for execution and program-management-instructions. So maybe that should be split into two insert methods. One for program-management-instructions which can only add entries and never overwrite. And one for normal execution which can unify duplicate loads.
- filter program accounts in a transaction batch - filter the accounts that are missing in LoadedPrograms cache - load the programs before processing the transactions - unit tests
pgarg66
force-pushed
the
use-program-cache
branch
from
0393038
to
a2d6f6e
Compare
Lichtso
approved these changes
Feb 21, 2023
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
…0275) * Find and load missing programs in LoadedPrograms cache - filter program accounts in a transaction batch - filter the accounts that are missing in LoadedPrograms cache - load the programs before processing the transactions - unit tests * address review comments * fix clippy * address review comments * fix test * fix more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LoadedProgram cache is currently unused.
Summary of Changes
Find and load missing programs in LoadedPrograms cache
Fixes #