Code to load a program from its account #30282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
loader-update
branch
2 times, most recently
from
e49b0f5
to
a349b74
Compare
Lichtso
reviewed
Feb 15, 2023
| impl LoadedPrograms { | ||
| /// Inserts a single entry | ||
| pub fn insert_entry(&mut self, key: Pubkey, entry: LoadedProgram) -> bool { | ||
| pub fn insert_entry(&mut self, key: Pubkey, entry: LoadedProgram) -> LoadedProgramEntry { |
There was a problem hiding this comment.
I don't think this change belongs into this PR.
At least insert_entry() is not used yet.
Lichtso
reviewed
Feb 15, 2023
programs/bpf_loader/src/lib.rs
Outdated
| let loaded_program = LoadedProgram::new( | ||
| program.get_owner(), | ||
| loader, | ||
| 0, // Fill in the deployment slot of the program |
There was a problem hiding this comment.
TODO left.
This could be returned in get_programdata_offset():
solana/programs/bpf_loader/src/lib.rs
Line 197 in a349b74
And maybe rename it to
get_programdata_offset_and_deployment_slot().
pgarg66
force-pushed
the
loader-update
branch
from
a349b74
to
c7ae903
Compare
Lichtso
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need API to load a program from its program and programdata account.
Summary of Changes
Added a new API to bpf_loader to load the program. Also updated
LoadedProgramstructure to store more meta data about the program.Fixes #