Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "change test validator from non upgradable bpf loader to upgra… #30409

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Revert "change test validator from non upgradable bpf loader to upgra… #30409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion validator/src/bin/solana-test-validator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ fn main() {

programs_to_load.push(ProgramInfo {
program_id: address,
loader: solana_sdk::bpf_loader_upgradeable::id(),
loader: solana_sdk::bpf_loader::id(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I had the same idea, But in genesis we pass the bootloader program id to specify which loader to use for the program.
Is old loader deprecated and we now use this loader for all the programs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your question. This change is a revert to the old immutable loader.
We are, however, considering proper support for the upgradeable loader in solana-test-validator, as well as defaulting to the upgradeable loader: #30412

program_path,
});
}
Expand Down