Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fnbool_to_FnOptionT #3041

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

rob-solana
Copy link
Contributor

Problem

epoch_vote_states() is clumsy, operates on a bool closure

Summary of Changes

move to Option, more flexible

Fixes #

Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I was thinking there was a double-call to get_balance that'd go away as a result of having this.

@garious
Copy link
Contributor

garious commented Mar 1, 2019

I see it. Need this same change to be made to vote_states().

@rob-solana rob-solana added the automerge Merge this Pull Request automatically once CI passes label Mar 1, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #3041 into master will increase coverage by <.1%.
The diff coverage is 92.8%.

@@           Coverage Diff            @@
##           master   #3041     +/-   ##
========================================
+ Coverage    77.2%   77.3%   +<.1%     
========================================
  Files         132     132             
  Lines       20182   20185      +3     
========================================
+ Hits        15599   15606      +7     
+ Misses       4583    4579      -4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants