Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature gate to set effective slot of loaded programs #30950

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Mar 29, 2023

Problem

The new cache sets effective slot of a program at the next slot to the deployment slot. If the program gets upgraded or deployed, it won't be active for another slot. This behavior should be covered under the existing feature gate delay_visibility_of_program_deployment.

Summary of Changes

If delay_visibility_of_program_deployment is not active, set the effective slot to the deployment slot. If the feature is active, set it to the next slot.

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso March 29, 2023 00:09
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #30950 (2fd8773) into master (bf986d6) will increase coverage by 0.0%.
The diff coverage is 87.9%.

@@           Coverage Diff            @@
##           master   #30950    +/-   ##
========================================
  Coverage    81.5%    81.5%            
========================================
  Files         727      727            
  Lines      205166   205444   +278     
========================================
+ Hits       167295   167542   +247     
- Misses      37871    37902    +31     

@pgarg66 pgarg66 merged commit f198d74 into solana-labs:master Mar 29, 2023
@pgarg66 pgarg66 deleted the effective-slot branch March 29, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants