Add expiration slot to loaded program cache entry #31034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31034 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 728 728
Lines 205583 205620 +37
=========================================
- Hits 167711 167670 -41
- Misses 37872 37950 +78 |
|
Also prune or evict should clean up expired entries. Probably prune will do in terms of frequency. |
Discussed this over chat. This will be combined with rework of eviction code. |
| if working_slot.current_slot() >= entry.effective_slot | ||
| && working_slot.is_ancestor(entry.deployment_slot) | ||
| let current_slot = working_slot.current_slot(); | ||
| if entry |
There was a problem hiding this comment.
Just got thinking if this can be influenced by the fork graph.
What if a fork occurs and one only one fork we have a program upgrade.
Then it places a tombstone, and now that tombstone which has an expiration slot would prevent further lookback on all forks even if they did not upgrade the program.
There was a problem hiding this comment.
Yes, I think we should also check the ancestor relation of the deployment slot with the working slot in this condition. i.e. check for expiration only if the deployment slot is an ancestor of the current slot.
There was a problem hiding this comment.
That might not actually solve it. Need more thoughts on it.
There was a problem hiding this comment.
Thought some more about it. For a program that gets updated on a fork, the tombstone will be created with the corresponding deployment slot. So if we check that the deployment slot of the program is an ancestor of the working slot, it should solve the issue.
Problem
Need a way to mark cache entry valid for only a certain number of slots. This will be useful to replenish cache with programs using old feature map, while the new programs are being compiled and pre-loaded in the cache. This will also be useful to mark tombstones valid only for certain duration (e.g. for delay visibility feature).
Summary of Changes
extractto treat a program as missing if the latest matching cache entry is expired.Fixes #