Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding ancestor during program cache pruning #31118

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Apr 10, 2023

Problem

The program cache pruning fails to find the program deployed in ancestor slot while pruning the cache.

Summary of Changes

  • Added a unit-test to test the issue
  • Fix prune code to set the flag only if the ancestor slot is found

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso April 10, 2023 05:11
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #31118 (4fa8260) into master (12e3e8b) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #31118   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         728      728           
  Lines      206100   206114   +14     
=======================================
+ Hits       168098   168115   +17     
+ Misses      38002    37999    -3     

@pgarg66 pgarg66 merged commit 9629ef3 into solana-labs:master Apr 20, 2023
@pgarg66 pgarg66 deleted the cache-prune-fix branch April 20, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants