Internal structs for ThreadAware AccountRead/WriteLocks #31431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running an experiment w/ unlocking threads which requires using a
DashMap
inside the thread aware locks struct.The interface for DashMap is slightly different, and we cannot do in-place tuple destructuring like is currently done; The code ended up having
.0
, or.1
in several places which feels very brittle and less readable.Summary of Changes
Create simple structs to hold Account-specific read and write locks w/ named fields.
This makes changes (described above) cleaner if we end up doing that.
Fixes #