Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBF bench to account for delay visibility #31501

Merged
merged 1 commit into from
May 5, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented May 4, 2023

Problem

SBF bench fails to execute transactions using the loaded program with the new LoadedPrograms cache.

Summary of Changes

This is similar to #31491. The loaded program is not effective till the next slot. This PR updates bank_client to next slot's bank as the program is available in the next slot's bank.

Fixes #

@pgarg66 pgarg66 requested a review from dmakarov May 4, 2023 23:07
@pgarg66 pgarg66 added the automerge Merge this Pull Request automatically once CI passes label May 4, 2023
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 4, 2023
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

automerge label removed due to a CI failure

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #31501 (4777938) into master (de43ac4) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #31501     +/-   ##
=========================================
- Coverage    81.4%    81.4%   -0.1%     
=========================================
  Files         731      731             
  Lines      208748   208748             
=========================================
- Hits       169995   169991      -4     
- Misses      38753    38757      +4     

@pgarg66 pgarg66 merged commit cc24d22 into solana-labs:master May 5, 2023
@pgarg66 pgarg66 deleted the update-sbf-bench branch May 5, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants