Programs deployed before the latest root available on all current forks #31530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31530 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 731 731
Lines 205112 205115 +3
=========================================
- Hits 166994 166976 -18
- Misses 38118 38139 +21 |
Lichtso
reviewed
May 8, 2023
Lichtso
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
WorkingSlotonly tracks ancestor till the latest root. If the program was deployed prior to the latest root, it fails the ancestor check inLoadedProgramscache.Summary of Changes
The
LoadedProgramsgets notified of new roots viaprune()API calls. This change tracks the latest root in the cache, and treats all programs deployed prior to the latest root as available on all current forks. Since, pruning removes all forks that are unreachable from the new root.Also updated the relevant unit tests to account for pruning and roots.
Fixes #