Remove executor cache from the codebase #31566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31566 +/- ##
=========================================
- Coverage 81.3% 81.2% -0.1%
=========================================
Files 734 733 -1
Lines 205128 204760 -368
=========================================
- Hits 166906 166463 -443
- Misses 38222 38297 +75 |
Lichtso
reviewed
May 10, 2023
runtime/src/bank.rs
Outdated
| @@ -7708,7 +7577,7 @@ impl Bank { | |||
| // Clear new account | |||
| self.store_account(new_address, &AccountSharedData::default()); | |||
|
|
|||
| self.remove_executor(old_address); | |||
| self.unload_program(old_address); | |||
There was a problem hiding this comment.
An unloaded entry still means that the new version has been verified against the current feature set, which is not the case here.
There was a problem hiding this comment.
That's correct. Let me change it to remove the entry instead.
Lichtso
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ExecutorCachehas been replaced withLoadedPrograms. The obsolete code should be deleted.Summary of Changes
Remove
ExecutorCachefrom the codebase.Fixes #