local-cluster: use feature flag for size for vote accounts #31723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
fix-new-vote-state-local-cluster
branch
from
f80d837
to
cfbf87e
Compare
Codecov Report
@@ Coverage Diff @@
## master #31723 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 736 736
Lines 205950 205950
=======================================
+ Hits 168673 168690 +17
+ Misses 37277 37260 -17 |
AshwinSekar
commented
May 19, 2023
| @@ -668,7 +679,8 @@ impl LocalCluster { | |||
| }, | |||
| amount, | |||
| vote_instruction::CreateVoteAccountConfig { | |||
| space: vote_state::VoteStateVersions::vote_state_size_of(true) as u64, | |||
There was a problem hiding this comment.
this was fine before because all the multi node local cluster tests used ClusterType::Development which turns on all the flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Local cluster assumes that the feature flag
vote_state_add_vote_latencyis always turned on when creating a new vote account on the cluster. This causesVoteInstruction::InitializeAccountto fail if the feature flag is not actually turned on.Summary of Changes
Check the status of the feature flag before creating new vote accounts.
Fixes #