Reset program cache stats after submit #31929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example: The following graph is for LoadedPrograms stats vs, the graph for executor cache stats |
Lichtso
approved these changes
Jun 2, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit 29d7a57)
pgarg66
pushed a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cache stats are monotonically increasing, since the same cache object is being shared for all banks. This makes it hard to compare the stats with previous implementation. Also, the stats will eventually rollover.
Summary of Changes
Reset the stats when a new bank in created, after submitting to the database.
Fixes #