Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce max staked streams count to avoid fragmentations #32771

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Reduce max staked streams count to avoid fragmentations #32771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1cdf29
Changed QUIC_MAX_STAKED_CONCURRENT_STREAMS to 1024
lijunwangs Jul 28, 2023
b9fe922
Changed QUIC_MAX_STAKED_CONCURRENT_STREAMS to 512
lijunwangs Jul 31, 2023
060c821
Update staked window instead
lijunwangs Aug 2, 2023
30b66b3
Revert "Update staked window instead"
lijunwangs Aug 2, 2023
f9daf9a
fixed unit test
lijunwangs Aug 9, 2023
dc4831e
Added comments
lijunwangs Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdk/src/quic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ pub const QUIC_MIN_STAKED_CONCURRENT_STREAMS: usize = 128;

pub const QUIC_TOTAL_STAKED_CONCURRENT_STREAMS: usize = 100_000;

// Set the maximum concurrent stream numbers to avoid excessive streams
pub const QUIC_MAX_STAKED_CONCURRENT_STREAMS: usize = 2048;
// Set the maximum concurrent stream numbers to avoid excessive streams.
// The value was lowered from 2048 to reduce contention of the limited
// receive_window among the streams which is observed in CI bench-tests with
// forwarded packets from staked nodes.
pub const QUIC_MAX_STAKED_CONCURRENT_STREAMS: usize = 512;
ryleung-solana marked this conversation as resolved.
Show resolved Hide resolved

pub const QUIC_MAX_TIMEOUT: Duration = Duration::from_secs(2);
pub const QUIC_KEEP_ALIVE: Duration = Duration::from_secs(1);
Expand Down
3 changes: 2 additions & 1 deletion streamer/src/nonblocking/quic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1934,7 +1934,8 @@ pub mod test {
);
assert_eq!(
compute_max_allowed_uni_streams(ConnectionPeerType::Staked, 100, 10000),
(delta / (100_f64)) as usize + QUIC_MIN_STAKED_CONCURRENT_STREAMS
((delta / (100_f64)) as usize + QUIC_MIN_STAKED_CONCURRENT_STREAMS)
.min(QUIC_MAX_STAKED_CONCURRENT_STREAMS)
);
assert_eq!(
compute_max_allowed_uni_streams(ConnectionPeerType::Staked, 0, 10000),
Expand Down