Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check source_path before delete it #33255

Merged
merged 1 commit into from
Sep 14, 2023
Merged

check source_path before delete it #33255

merged 1 commit into from
Sep 14, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Sep 14, 2023

Problem

when I tried to migrate tests in solana-cargo-build-sbf to nextest. I found that we don't check the proper path before actually removing it

Summary of Changes

check source_path before removing it.

@yihau yihau requested a review from dmakarov September 14, 2023 17:51
@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Sep 14, 2023
@mergify mergify bot merged commit 99b24bd into solana-labs:master Sep 14, 2023
42 checks passed
@yihau yihau deleted the fix-remove-folder branch September 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmakarov dmakarov dmakarov approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihau @dmakarov