Enable running remote cargo registry server #33629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33629 +/- ##
=========================================
Coverage 81.8% 81.8%
=========================================
Files 766 806 +40
Lines 209084 217456 +8372
=========================================
+ Hits 171145 178000 +6855
- Misses 37939 39456 +1517 |
|
Hmm, I think people can figure out their public IP addresses by other means. Also, they will have to setup the port forwarding in their firewall / NAT anyway. |
We can add command line parameters to configure public IP and port. |
pgarg66
force-pushed
the
cargo-remote-registry
branch
from
6b03f9e
to
18fa727
Compare
Lichtso
approved these changes
Oct 10, 2023
pgarg66
force-pushed
the
cargo-remote-registry
branch
from
18fa727
to
5da95e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The registry server cannot accessed if it is running on a remote machine.
Summary of Changes
The registry index configuration contains the URL of the web API. This must contain the public IP of the server, if the server is running remotely.
This PR adds an optional command line argument to the server, which if used will identify machine's public IP address. This IP will be filled in the the index configuration.
Fixes #