Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve crate version from cargo-registry package #33867

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Oct 25, 2023

Problem

Crate version is hardcoded to 0.1.0 in registry server.

Summary of Changes

  • Compute the crate version from the uploaded program
  • Use the computed version in registry index

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso October 25, 2023 17:40
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #33867 (2bb1216) into master (bdfb644) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #33867     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         809      809             
  Lines      217692   217692             
=========================================
- Hits       178276   178256     -20     
- Misses      39416    39436     +20     

@pgarg66 pgarg66 marked this pull request as ready for review October 25, 2023 19:27
@pgarg66 pgarg66 merged commit 70107e2 into solana-labs:master Oct 25, 2023
32 checks passed
@pgarg66 pgarg66 deleted the crate-version branch October 25, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants