[zk-token-proof] Round compute units to nice numbers #33910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33910 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 809 809
Lines 218062 218062
=========================================
- Hits 178672 178649 -23
- Misses 39390 39413 +23 |
samkim-crypto
added
v1.17
tao-stones
approved these changes
Oct 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
round zk-token-proof compute units to nice numbers (cherry picked from commit b0bf24b)
samkim-crypto
added a commit
that referenced
this pull request
Oct 28, 2023
… of #33910) (#33915) [zk-token-proof] Round compute units to nice numbers (#33910) round zk-token-proof compute units to nice numbers (cherry picked from commit b0bf24b) Co-authored-by: samkim-crypto <[email protected]>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
… of solana-labs#33910) (solana-labs#33915) [zk-token-proof] Round compute units to nice numbers (solana-labs#33910) round zk-token-proof compute units to nice numbers (cherry picked from commit b0bf24b) Co-authored-by: samkim-crypto <[email protected]>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
… of solana-labs#33910) (solana-labs#33915) [zk-token-proof] Round compute units to nice numbers (solana-labs#33910) round zk-token-proof compute units to nice numbers (cherry picked from commit b0bf24b) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The compute units that are assigned to each zk-token-proof instructions are very specific numbers that are computed by benching the instructions on dev machines and assigning 1 CU per 33ns. Since these numbers are approximate anyway, it would be nicer to round off these CUs for easier communication as pointed out in #31788 (comment).
Summary of Changes
Rounded off the numbers for the zk-token-proof CUs. For the u128 range proof compute units, I went a little aggressive with the rounding since it will be really nice to fit that under the 200k compute budget limit.
Note: the zk-token-proof program has not yet been activated on any of the servers.
Fixes #