Fix - Bank::compute_active_feature_set() and Bank::apply_feature_activations()

[Lichtso]

Problem

A feature activation on devnet diverged because it was activated before the epoch boundary on part of the cluster (version dependent). This happened because of the backport #34003 which depends on Bank::compute_active_feature_set() being without side effects (as the name suggests).

Summary of Changes

Move the actual activation of pending features from Bank::compute_active_feature_set() into Bank::apply_feature_activations().

[steviez]

I'm inclined to think this unit test will now fail:

solana/runtime/src/bank/tests.rs

Line 7727 in e589c07

fn test_compute_active_feature_set() {

Aside from Bank::apply_feature_activations(), this unit test looks to be the only other caller of Bank::compute_active_feature_set() so that unit test should be the only other things that needs to be updated

[pgarg66]

I'm inclined to think this unit test will now fail:

solana/runtime/src/bank/tests.rs

Line 7727 in e589c07

fn test_compute_active_feature_set() {

Aside from Bank::apply_feature_activations(), this unit test looks to be the only other caller of Bank::compute_active_feature_set() so that unit test should be the only other things that needs to be updated

You're right. That test is failing.

[codecov]

Codecov Report

Merging #34124 (0942241) into master (b4c652e) will decrease coverage by 0.1%.
Report is 8 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #34124     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         816      816             
  Lines      219753   219759      +6     
=========================================
+ Hits       180001   180004      +3     
- Misses      39752    39755      +3     

[steviez]

Looks good to me!