Break replay_stage::new into more functions #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! "Re: see title" the convention we've been using is that the title of the PR is a quick summary of the "Summary of Changes" whereas the title of an issue is a quick summary of the problem. |
sakridge
changed the title
break into more functions
sakridge
force-pushed
the
replay-stage-refactor
branch
from
a39e39e
to
1e8758f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3415 +/- ##
========================================
+ Coverage 79.9% 81% +1.1%
========================================
Files 147 152 +5
Lines 23022 22806 -216
========================================
+ Hits 18404 18488 +84
+ Misses 4618 4318 -300 |
carllin
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
replay_stage::new is too long.
Summary of Changes
See title.
Fixes #