-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish crates directly #34794
ci: publish crates directly #34794
Conversation
Linking this for history/context: #5136 This seems like a decent approach to me, although there might be some value in retaining the REST api check. Let's wait to hear from @t-nelson, though, as I know he was also exploring some options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit f9bfb60)
ci: publish crates directly (#34794) (cherry picked from commit f9bfb60) Co-authored-by: Yihau Chen <[email protected]>
Problem
a related convo: https://discord.com/channels/428295358100013066/560503042458517505/1196572613523279942
Summary of Changes
return an error when the crate fails to publish
=> sometimes we receive reports about missing crates. I think we can detect these issues earlier and take appropriate actions (like re-publish or move to next tag)
use the check which is already in
cargo publish
instead of crate test=> I guess we use crate-test for ensuring the successful publishing of the next crate 🤔 maybe we can just retry
cargo publish
. this command will tell us if anything goes wrong. (like dependences are not ready or building error)these are big changes to our existing publish pipeline. let me know what you think. btw, I will only backport it to v1.17. I think our v1.16 will never pass this one atm🙈