Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: bump shlex to 1.3.0 #34880

Merged
merged 1 commit into from
Jan 23, 2024
Merged

v1.17: bump shlex to 1.3.0 #34880

merged 1 commit into from
Jan 23, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Jan 22, 2024

Problem

Summary of Changes

Fixes #

@yihau
Copy link
Member Author

yihau commented Jan 22, 2024

@yihau yihau changed the title v1.17: bump shlex to 1.2.1 v1.17: bump shlex to 1.3.0 Jan 22, 2024
@yihau yihau marked this pull request as ready for review January 22, 2024 19:30
@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Jan 22, 2024
@t-nelson
Copy link
Contributor

wow it looks like 2024 is the year of dependencies showing their ass. one more for the "to remove" list

@t-nelson
Copy link
Contributor

can you squash the 1.2.1 attempt away?

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c8a23a) 81.7% compared to head (fbab3eb) 81.7%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34880     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         806      806             
  Lines      218925   218925             
=========================================
- Hits       178877   178866     -11     
- Misses      40048    40059     +11     

@solana-grimes
Copy link
Contributor

😱 New commits were pushed while the automerge label was present.

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jan 23, 2024
@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Jan 23, 2024
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jan 23, 2024
Copy link
Contributor

mergify bot commented Jan 23, 2024

automerge label removed due to a CI failure

@t-nelson t-nelson merged commit cdda274 into solana-labs:v1.17 Jan 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants