Issue #336: Added throttling of repair messages (will add the retransmission of repair messages logic soon) #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
changed the title
carllin
changed the title
garious
reviewed
Jun 17, 2018
| @@ -611,6 +622,10 @@ impl Crdt { | |||
| //come up with a cleaner solution for this when sender signatures are checked | |||
| outblob.set_id(from.id).expect("blob set_id"); | |||
| } | |||
|
|
|||
| drop(rblob); | |||
There was a problem hiding this comment.
Instead of dropping that, can you pass it back to the recycler?
There was a problem hiding this comment.
No problem, I'll add some tests. Here, I just wanted to release the read lock so that I can obtain the write lock to modify the blob, not free the underlying blob to the recycler.
carllin
changed the title
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336