remove IPADDR, which was making Rob feel ill #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPADDR is simple, but not exactly what we need for testnet, where NAT'd folks need to join in, need to advertize themselves as on the interweb. myip() helps, but there's some TODOs: fullnode-config probably needs to be told where it lives in the real world (machine interfaces tell us dick), or incorporate something like the "ifconfig.co" code in myip.sh
garious
approved these changes
Jun 23, 2018
|
@rob-solana don't you think we will need physical vs virtual IPs? Basically |
|
this PR allows the user to decide whether he's going to run a network on his internal network or talk to the real world. the default choice is to use the interface that presents in the real world (via http://ifconfig.co) |
|
rebase and shellcheck? Feel free to automerge on successful CI |
|
(The publish-snap ci job is still red so auto merge will fail. Fixing this today...) |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
godmodegalactus
pushed a commit
to blockworks-foundation/solana
that referenced
this pull request
Jan 5, 2024
Use cluster info functions for tpu (solana-labs#345) (solana-labs#347) Use git rev-parse for git sha Remove blacklisted tx from message_hash_to_transaction (Backport solana-labs#374) (solana-labs#376) Updates scripts for easy local setup. (solana-labs#383) Backports sim_bundle improvements (solana-labs#407) backports clone derivation 416 (solana-labs#417) Backport solana-labs#419: add upsert to AccountOverrides (solana-labs#420) backports solana-labs#430 v1.16: update jito-programs sha (solana-labs#431) [JIT-1661] Faster Autosnapshot (solana-labs#406) Fix Buildkite warnings (solana-labs#437) Backport solana-labs#446 to v1.16 (solana-labs#447) backport 428, runtime plugin (solana-labs#429) v1.16: Backport solana-labs#449 (solana-labs#450)
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Mar 25, 2024
…-labs#417) Add examples of failing transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPADDR is simple, which is nice, but not exactly what we need for testnet, where NAT'd
folks need to join in, need to advertize themselves as on the interweb.
myip() helps, but there's some TODOs: fullnode-config probably needs to
be told where it lives in the real world (machine interfaces tell us dick),
or incorporate something like the "ifconfig.co" code in myip.sh