Move public IP address detection out of bash #499

mvines · 2018-06-30T00:56:55Z

Includes further refinement/churn of the setup.sh/solana-fullnode-config` CLI arguments. The options are:

Use local address (may be a private IP):

$ ./multinode-demo/setup.sh
.. or ..
$ ./multinode-demo/setup.sh -l

Use the detected public address (forced for the snap-based fullnode daemon):

./multinode-demo/setup.sh -p

mvines · 2018-06-30T00:59:22Z

@garious I think this is a little nicer for the snap setup at least. My Rust is still pretty terrible so donno what you think about bringing in that curl create dependency

garious

:)

garious · 2018-06-30T01:40:09Z

src/nat.rs

@@ -16,6 +19,31 @@ pub struct UdpSocketPair {
    pub sender: UdpSocket,   // Locally bound socket to send via public address
 }

+/// Tries to determine the public IP address of this machine, returns 0.0.0.0 on
+/// failure
+pub fn get_public_ip_addr() -> IpAddr {


This should return a Result. There's enough things to go wrong.

garious · 2018-06-30T01:42:46Z

Good thinking on defaulting local.

mvines · 2018-06-30T02:38:32Z

Gross this brings in an openssl dependency that's breaking sagan and the snap build.

garious · 2018-06-30T03:03:14Z

An openssl dep seems pretty unavoidable. A broken one is disappointing.

garious · 2018-06-30T03:08:10Z

nat put a dependency on hyper. Might as well add https://docs.rs/reqwest/0.8.6/reqwest/?

solana-grimes · 2018-06-30T03:30:25Z

💔 Unable to automerge due to merge conflict

mvines · 2018-06-30T03:31:41Z

🚍

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525) Faster MEV tip claiming (v1.17) (solana-labs#568) Backport Release Fixes (solana-labs#586)

#499) ci: fix some issues for the release pipeline (#493) * add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id (cherry picked from commit b1e1799) Co-authored-by: Yihau Chen <[email protected]>

…na-labs#493) (solana-labs#499) ci: fix some issues for the release pipeline (solana-labs#493) * add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id (cherry picked from commit b1e1799) Co-authored-by: Yihau Chen <[email protected]>

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525) Faster MEV tip claiming (v1.17) (solana-labs#568) Backport Release Fixes (solana-labs#586)

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525) Faster MEV tip claiming (v1.17) (solana-labs#568) Backport Release Fixes (solana-labs#586) Update release URLs for jito-solana (solana-labs#589) Backports solana-labs#595: correctly initialize account overrides (solana-labs#599) Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601) Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)

mvines requested a review from garious June 30, 2018 00:58

garious approved these changes Jun 30, 2018

View reviewed changes

garious reviewed Jun 30, 2018

View reviewed changes

mvines force-pushed the public_ip branch 2 times, most recently from 84a1910 to 08edf46 Compare June 30, 2018 02:21

mvines added the work in progress This isn't quite right yet label Jun 30, 2018

mvines force-pushed the public_ip branch from 08edf46 to 6a03fbe Compare June 30, 2018 03:22

mvines removed the work in progress This isn't quite right yet label Jun 30, 2018

garious approved these changes Jun 30, 2018

View reviewed changes

mvines added the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018

solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018

Move public IP address detection out of bash

3dc0d41

mvines force-pushed the public_ip branch from 6a03fbe to 3dc0d41 Compare June 30, 2018 03:33

mvines added the automerge Merge this Pull Request automatically once CI passes label Jun 30, 2018

solana-grimes merged commit 450f271 into solana-labs:master Jun 30, 2018

mvines deleted the public_ip branch July 8, 2018 03:10

CriesofCarrots pushed a commit that referenced this pull request Feb 28, 2020

fix: flow expose transactionInstruction (#499)

5102202

mvines pushed a commit to mvines/solana that referenced this pull request Jun 15, 2020

fix: flow expose transactionInstruction (solana-labs#499)

28a6409

mvines pushed a commit that referenced this pull request Jun 15, 2020

fix: flow expose transactionInstruction (#499)

c31ca1f

masakazu12 mentioned this pull request Mar 22, 2024

[Snyk] Security upgrade @crowdin/cli from 3.9.0 to 3.9.2 masakazu12/solana#12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move public IP address detection out of bash #499

Move public IP address detection out of bash #499

mvines commented Jun 30, 2018

mvines commented Jun 30, 2018

garious left a comment

garious Jun 30, 2018

garious commented Jun 30, 2018

mvines commented Jun 30, 2018

garious commented Jun 30, 2018

garious commented Jun 30, 2018

solana-grimes commented Jun 30, 2018

mvines commented Jun 30, 2018

Move public IP address detection out of bash #499

Move public IP address detection out of bash #499

Conversation

mvines commented Jun 30, 2018

mvines commented Jun 30, 2018

garious left a comment

Choose a reason for hiding this comment

garious Jun 30, 2018

Choose a reason for hiding this comment

garious commented Jun 30, 2018

mvines commented Jun 30, 2018

garious commented Jun 30, 2018

garious commented Jun 30, 2018

solana-grimes commented Jun 30, 2018

mvines commented Jun 30, 2018