Book: Update durable nonce proposal entry #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
force-pushed
the
book-sync-nonce-prop
branch
from
802a030
to
8bb41c6
Compare
|
Should all be addressed in 8bb41c6. Thanks for the review! |
t-nelson
added
the
automerge
garious
reviewed
Jan 13, 2020
| the system program. This account will be in the `Uninitialized` state with no | ||
| stored hash, and thus unusable. | ||
|
|
||
| To initialize a newly created account, a `NonceInitialize` instruction must be |
There was a problem hiding this comment.
Jumping in late here, but was surprised to see the Nonce prefix on every instruction. What's that about? No other program does that.
There was a problem hiding this comment.
The prefixes were added when nonce was moved under the system program
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2020
automerge (cherry picked from commit ef06d16)
solana-grimes
pushed a commit
that referenced
this pull request
Jan 13, 2020
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The durable nonce proposal entry no longer reflects the reality of its implementation
Summary of Changes
Adapt for:
Depends on #7684