Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coalesce data and coding index #7765

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

carllin
Copy link
Contributor

@carllin carllin commented Jan 12, 2020

Problem

Data and Coding Index structures have the same signature and methods, can be merged into one.

Summary of Changes

Replace DataIndex and CodingIndex with single ShredIndex struct
Fixes #

pgarg66
pgarg66 previously approved these changes Jan 12, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #7765 into master will decrease coverage by <.1%.
The diff coverage is 40%.

@@           Coverage Diff            @@
##           master   #7765     +/-   ##
========================================
- Coverage    81.8%   81.8%   -0.1%     
========================================
  Files         241     241             
  Lines       50903   50882     -21     
========================================
- Hits        41652   41632     -20     
+ Misses       9251    9250      -1

@mergify mergify bot dismissed pgarg66’s stale review January 13, 2020 05:26

Pull request has been modified.

@carllin carllin merged commit 8f7ded3 into solana-labs:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants