Remove create_account bandaid now that to's signature is required
#7776
Conversation
rob-solana
force-pushed
the
Add-split-with-seed
branch
from
58b7bcc
to
f10a5c3
Compare
rob-solana
changed the title
to requires signatureto requires signature
Codecov Report
@@ Coverage Diff @@
## master #7776 +/- ##
========================================
- Coverage 81.8% 81.8% -0.1%
========================================
Files 239 242 +3
Lines 51203 51236 +33
========================================
+ Hits 41932 41959 +27
- Misses 9271 9277 +6 |
rob-solana
force-pushed
the
Add-split-with-seed
branch
from
f10a5c3
to
e130bfe
Compare
rob-solana
changed the title
to requires signatureto's signature is required
sdk/src/system_instruction.rs
Outdated
| @@ -147,7 +147,7 @@ pub fn create_account( | |||
| program_id: &Pubkey, | |||
| ) -> Instruction { | |||
| let account_metas = vec
There was a problem hiding this comment.
What's the point of this feature exactly? And if you use it, why require from_pubkey?
There was a problem hiding this comment.
I could round out system program with another set of functions/instructions that don't require a from, but I think they'd only manifest as system_instruction.rs entry points, as so many things funnel down.
My next PR makes clear the value of this feature. Stay tuned!
There was a problem hiding this comment.
Something still smells funny here. Is it possible that CreateAccount shouldn't have from or lamports parameters at all?
There was a problem hiding this comment.
your new issue nicely describes what I'm going for here
There was a problem hiding this comment.
Good to hear! So baby steps, how about we leave CreateAccount alone and instead add the proposed Allocate instruction in this PR?
rob-solana
force-pushed
the
Add-split-with-seed
branch
from
e130bfe
to
f4b4842
Compare
mergify
bot
dismissed
t-nelson’s stale review
Pull request has been modified.
Problem(s)
create_account() checks
tobalance, but shouldn't as long asthere's no existing data and the system account is the owner (redundant with
verify_account_changes(), but no biggie)Summary of Changes
remove the balance check for
toFixes #