Plumb ability to handle duplicate shreds into shred insertion functions #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
FixReplayStage
branch
from
b5b56b0
to
620adae
Compare
carllin
force-pushed
the
FixReplayStage
branch
from
620adae
to
6a71841
Compare
Codecov Report
@@ Coverage Diff @@
## master #7784 +/- ##
========================================
+ Coverage 81.9% 81.9% +<.1%
========================================
Files 241 241
Lines 51070 51081 +11
========================================
+ Hits 41841 41854 +13
+ Misses 9229 9227 -2 |
This was referenced Aug 1, 2022
This was referenced Aug 2, 2022
This was referenced Aug 22, 2022
This was referenced Aug 24, 2022
Open
Open
Open
Open
This was referenced May 14, 2024
Open
Open
Open
Open
This was referenced May 22, 2024
This was referenced May 22, 2024
This was referenced Oct 12, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shred insertion doesn't have a mechanism to call a handler upon seeing a duplicate shred
Summary of Changes
Plumb ability to call a handler upon detection of duplicate shreds
Fixes #