Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage.sh usability when used locally #9054

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Improve coverage.sh usability when used locally #9054

merged 2 commits into from
Mar 24, 2020

Conversation

ryoqun
Copy link
Member

@ryoqun ryoqun commented Mar 24, 2020

Summary of Changes

  • Restrict cleared coverage files really to be regular files for responsibility separation for each code blocks
  • Guard on-going find invocation with cov/after-test against newly-created symlinks to be matched
  • Always generate report and restore non-successful exit status at last if any
  • Introduce LATEST symlink for easier reloading without re-navigating.
  • Skip full-clean build when not under CI or when testing only some.

@ryoqun ryoqun requested a review from mvines March 24, 2020 19:31
mvines
mvines previously approved these changes Mar 24, 2020
View reviewed changes
scripts/coverage.sh Outdated Show resolved Hide resolved
scripts/coverage.sh Outdated Show resolved Hide resolved
@mergify mergify bot dismissed mvines’s stale review March 24, 2020 19:59

Pull request has been modified.

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Mar 24, 2020
@solana-grimes solana-grimes merged commit 216b01b into solana-labs:master Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b0c8392). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #9054   +/-   ##
========================================
  Coverage          ?   80.4%           
========================================
  Files             ?     267           
  Lines             ?   58543           
  Branches          ?       0           
========================================
  Hits              ?   47073           
  Misses            ?   11470           
  Partials          ?       0

carllin pushed a commit to carllin/solana that referenced this pull request Mar 24, 2020
@ryoqun @carllin
Improve coverage.sh usability when used locally (solana-labs#9054)
4624cc7 
automerge
@ryoqun ryoqun added the v1.0 label Apr 10, 2020
mergify bot pushed a commit that referenced this pull request Apr 10, 2020
@ryoqun
Improve coverage.sh usability when used locally (#9054)
d3894c5 
automerge

(cherry picked from commit 216b01b)
@mergify mergify bot mentioned this pull request Apr 10, 2020
Merged
@ryoqun
Copy link
Member Author

ryoqun commented Apr 10, 2020 •
edited
Loading

I wanted and cherry-picked locally this for #9357, so back-port to v1.0 just in case for future use. But, I hope we don't need to debug that branch in the future....

solana-grimes pushed a commit that referenced this pull request Apr 10, 2020
@mergify
Improve coverage.sh usability when used locally (#9054) (#9424)
00b4186 
automerge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvines mvines mvines left review comments

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryoqun @mvines @solana-grimes