Rework repair stats #9094
Merged
Rework repair stats #9094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
repair-stats-rework
branch
from
a0f29cf
to
0b74452
Compare
Codecov Report
@@ Coverage Diff @@
## master #9094 +/- ##
========================================
- Coverage 80.4% 80.4% -0.1%
========================================
Files 269 269
Lines 58796 58996 +200
========================================
+ Hits 47319 47468 +149
- Misses 11477 11528 +51 |
|
@carllin I split the other PR to just update the repair stat handling in this. I'll fix the dos in the other PR. |
aeyakovenko
approved these changes
Mar 29, 2020
aeyakovenko
approved these changes
Mar 29, 2020
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2020
(cherry picked from commit c67703e)
solana-grimes
pushed a commit
that referenced
this pull request
Mar 29, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
May 16, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
May 16, 2020
sakridge
added a commit
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Repair stats print too often causing confusion for validators.
Summary of Changes
Accumulate stats and print only at 1s interval.
Fixes #