Refactored large network test to use finality to assert success #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
changed the title
pgarg66
force-pushed
the
refactor-large-nw-test
branch
2 times, most recently
from
cc1ac20
to
dbc2858
Compare
|
Also increased the node count to 200. Wondering if any checks should be stricter... |
garious
approved these changes
Aug 15, 2018
aeyakovenko
reviewed
Aug 15, 2018
tests/multinode.rs
Outdated
|
|
||
| let now = Instant::now(); | ||
| let mut finality = client.get_finality(); | ||
| while finality == last_finality { |
There was a problem hiding this comment.
while duration_as_ms(now.elapsed()) < client.get_finality() {
sleep(Duration::from_millis(100));
}
right? if finality is longer then T since confirmation we wait. If its shorter that means 2/3rds of the validators have moved passed T.
aeyakovenko
reviewed
Aug 15, 2018
tests/multinode.rs
Outdated
| let mut retain_me = true; | ||
| let mut client = mk_client(&server.0); | ||
| trace!("{:x} get_balance start", server.0.debug_id()); | ||
| let getbal = retry_get_balance(&mut client, &bob_pubkey, Some(expected_balance)); |
There was a problem hiding this comment.
i would change this to just confirm the last sig in all the validators instead of retry get balance.
pgarg66
force-pushed
the
refactor-large-nw-test
branch
from
dbc2858
to
ecf120f
Compare
|
@aeyakovenko , the latest patch addresses all the comments. |
aeyakovenko
approved these changes
Aug 16, 2018
garious
approved these changes
Aug 16, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…#978) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.1.2...v4.1.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yihau
pushed a commit
that referenced
this pull request
Apr 26, 2024
…864) (#978) limits number of nodes per IP address in Turbine (#864) (cherry picked from commit c87b830) Co-authored-by: behzad nouri <[email protected]>
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
May 1, 2024
…olana-labs#864) (solana-labs#978) limits number of nodes per IP address in Turbine (solana-labs#864) (cherry picked from commit c87b830) Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.