Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 sd-display main size variant #1412

Merged
merged 4 commits into from
Sep 25, 2024
Merged

fix: 🤔 sd-display main size variant #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bd86b5
fix: changed main size variant
yoezlem Sep 19, 2024
7456c6c
fix: typo
yoezlem Sep 19, 2024
b952e57
fix: typo
yoezlem Sep 19, 2024
49432da
doc: changed description
yoezlem Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/components/src/styles/display/display.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
.sd-display {
@apply text-xl font-normal leading-tight text-black;
@apply text-3xl lg:text-4xl font-normal leading-tight text-black;

&--size {
&-3xl {
@apply text-2xl lg:text-3xl font-normal leading-tight text-black;
&-xl {
@apply text-xl font-normal leading-tight text-black;
}

&-4xl {
@apply text-3xl lg:text-4xl font-normal leading-tight text-black;
&-3xl {
@apply text-2xl lg:text-3xl font-normal leading-tight text-black;
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/styles/display/display.declaration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
attributes: [
{
name: 'sd-display--size-...',
options: ['3xl', '4xl'],
options: ['xl', '3xl'],
description: "The display's size."
},
{
Expand Down
10 changes: 5 additions & 5 deletions packages/components/src/styles/display/display.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ export const Default = {
/**
* Use the `&--size-*` classes for alternative appearances.

* - `sd-display--size-4xl`: 4xl can be used as an alternative
* - `sd-display--size-3xl`: 3xl can be used as an alternative
* - xl is the default display size
* - `sd-display` (default)
* - `sd-display--size-3xl`
* - `sd-display--size-xl`
*/

export const Size = {
render: () => html`
<div class="flex flex-col gap-6">
<div class="sd-display sd-display--size-4xl">Lorem ipsum</div>
<div class="sd-display sd-display--size-3xl">Lorem ipsum</div>
<div class="sd-display">Lorem ipsum</div>
<div class="sd-display sd-display--size-3xl">Lorem ipsum</div>
<div class="sd-display sd-display--size-xl">Lorem ipsum</div>
</div>
`
};
Expand Down
Loading