Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wac-ucr] add initial definitions #83

Closed
wants to merge 5 commits into from
Closed

Conversation

justinwb
Copy link
Member

@justinwb justinwb commented Jul 9, 2020

Initial set of definitions for the WAC use cases and requirements document.

@justinwb justinwb requested a review from a team July 9, 2020 17:45
proposals/wac-ucr/index.bs Outdated Show resolved Hide resolved
@@ -42,5 +42,111 @@ This is where we explain the use case.
Definitions {#definitions}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the UCR defining terminology instead of referring to where they are actually defined?

The UCR should have no knowledge about the things that's being defined here. When this is defined, it is reverse-engineering the UCR where it should instead work from its own needs to come up with the requirements.

The criteria in the WAC spec will backreference the requirements in UCR.

Comment on lines +103 to +122
An <dfn>access mode</dfn> denotes a class of operations that an
[=authorization subject=] can perform on an [=authorization target=] in an
[=authorization statement=].

<dfn>Read access</dfn> is an [=access mode=] that allows the
[=authorization subject=] to the ability to read, but not modify, the
[=authorization target=].

<dfn>Write access</dfn> is an [=access mode=] that allows the
[=authorization subject=] to the ability to create, update, or delete the
[=authorization target=].

<dfn>Append access</dfn> is an [=access mode=] that allows the
[=authorization subject=] to add data to a resource, but not modify any
data that already exists.
[=authorization target=].

<dfn>Control access</dfn> is an [=access mode=] that allows the
[=authorization subject=] to view and modify [=acl resources=] associated
with an [=authorization target=].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be defined in the UCR? If it is referring to the ACL vocab, simply refer to that.

@justinwb
Copy link
Member Author

Closing this PR as it has been superseded by #84. Note that this branch was merged with the use cases branch and is included in #84. However, given the extensive use of definition links in use cases I think it does a better job of explaining how they're used in context, which felt appropriate.

@justinwb justinwb closed this Jul 16, 2020
@csarven
Copy link
Member

csarven commented Jul 16, 2020

Can we make sure to address all comments/reviews to a PR before closing? At the very least ensure that there is a mutual understanding whether the comments/reviews are significant and need further attention. In this particular case, it is not clear whether https://github.com/solid/authorization-panel/pull/83/files/d89013a658479cff2c2f05f1a837b76dc6f518b7#r452461263 and https://github.com/solid/authorization-panel/pull/83/files#r452462668 are taken into account in the new PR. There are no back references indicating that they are addressed. It is just out of sight out of mind.

@matthieubosquet matthieubosquet deleted the uc-initial-definitions branch March 3, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants