Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vinxi] More Windows fixes #1113

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[vinxi] More Windows fixes #1113

merged 1 commit into from
Nov 6, 2023

Conversation

edivados
Copy link
Contributor

@edivados edivados commented Nov 5, 2023

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • Lazy route dynamic import not working
  • Runtime path on client router not normalized (import fails)

What is the new behavior?

  • Use new import helper in lazy route
  • Normalize runtime path on client router

Other information

@ryansolid ryansolid merged commit b1bed23 into solidjs:vinxi Nov 6, 2023
0 of 9 checks passed
@edivados edivados deleted the win-fix branch November 6, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants