Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(with-vitest): ➕ add missing dependencies #1498

Merged
merged 2 commits into from
May 23, 2024

Conversation

seahindeniz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

When I run pnpm test and pnpm coverage in the with-vitest example, I get the following errors

  • Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite-plugin-solid'
  • MISSING DEPENDENCY Cannot find dependency '@vitest/coverage-v8'

What is the new behavior?

Without the missing required dependencies, the scripts will run as expected

Other information

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 6be6434

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seahindeniz seahindeniz marked this pull request as ready for review May 22, 2024 21:23
@atk
Copy link
Contributor

atk commented May 23, 2024

Original author of that template here:

If you configure coverage to be collected, the package will be automatically installed. For those who don't collect it, it's a superfluous package, which is the reason it is not installed by default.

@seahindeniz
Copy link
Contributor Author

Hey @atk 👋. I added it because having a script to collect coverage with a missing dependency creates a bit unexpected visual for the first comer. At least that's how I felt first after trying out every script and then felt the urge to add them. First time users may even say this is a bug.
IMHO, the choice must start from the point of creating the script, rather then starting with and error 🙏

@atk
Copy link
Contributor

atk commented May 23, 2024

If that is the case then let us remove the script and add the ability to collect coverage to the documentation.

@seahindeniz
Copy link
Contributor Author

Just removed the script and the dep. I'm not sure how you mean document it but let me know what to add and where, I can assist, or please do a commit

@ryansolid
Copy link
Member

Thanks

@ryansolid ryansolid merged commit d442a83 into solidjs:main May 23, 2024
@seahindeniz seahindeniz deleted the build/add-vitest-dependencies branch May 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants