Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example with-drizzle #1501

Merged
merged 5 commits into from
May 28, 2024
Merged

Add example with-drizzle #1501

merged 5 commits into from
May 28, 2024

Conversation

thednp
Copy link
Contributor

@thednp thednp commented May 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

No example with a major growing ORM, Drizzle.

What is the new behavior?

Now we have an example similar to with-prisma but for drizzle.

Other information

Drizzle is an awesome ORM, SolidStart examples need something like this.

Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: ad9e9e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

I think something's going on with the types, `/// <reference types="@solidjs/start/env" />` shows error, but `/// <reference types="@solidjs/start" />` doesn't.
@ryansolid
Copy link
Member

Yeah those sort of ambient types have been giving me trouble a bit. And they seem to work differently outside and inside of the repo. Let's merge and see. Although the CLI will need to be updated to add this example.

@thednp
Copy link
Contributor Author

thednp commented May 24, 2024

Yeah those sort of ambient types have been giving me trouble a bit. And they seem to work differently outside and inside of the repo. Let's merge and see. Although the CLI will need to be updated to add this example.

I don't know everything in the Solid code base, but I'm sure it's something quick for you.

Not my business to update the parent folder pnpm-lockyaml file

@ryansolid please re-review
@ryansolid ryansolid merged commit 387b4ed into solidjs:main May 28, 2024
@ryansolid
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants